Revisit OpenMP detection - #499
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
data.table"decision tree" in theirconfigureshell script viaconfigure.ac. There are two broad cases: Linux and macOS, and within each different strategies are tested. It accommodates macOS three different ways, including homebrew.@coatless When you have a moment, please eyeball. It still contains a CI matrix with/without calling your installer script so we see these two aspects. I do not think I can automate homebrew testing but I trust the
data.tablechoices.I may comment-out some of the bits in the CI file before merging but for now it is helpful to have the additional output.